From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbcBHRHn (ORCPT ); Mon, 8 Feb 2016 12:07:43 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36799 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932177AbcBHRHk (ORCPT ); Mon, 8 Feb 2016 12:07:40 -0500 Date: Mon, 8 Feb 2016 22:37:36 +0530 From: Viresh Kumar To: Rafael Wysocki , juri.lelli@arm.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, skannan@codeaurora.org, peterz@infradead.org, mturquette@baylibre.com, steve.muckle@linaro.org, vincent.guittot@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, shilpa.bhat@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 03/13] cpufreq: governor: New sysfs show/store callbacks for governor tunables Message-ID: <20160208170736.GT8294@vireshk> References: <89c003851ca3be77cf3656805303bf4f36d585ea.1454931188.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89c003851ca3be77cf3656805303bf4f36d585ea.1454931188.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-02-16, 17:09, Viresh Kumar wrote: > +gov_show_one(sampling_rate); > +gov_show_one(sampling_down_factor); > +gov_show_one(up_threshold); > +gov_show_one(ignore_nice_load); > +gov_show_one(min_sampling_rate); > +gov_show_one_tunable(cs, down_threshold); > +gov_show_one_tunable(cs, freq_step); Based on the review comments on 1/13, I will do: - s/gov_show_one/gov_show_one_common - s/gov_show_one_tunable/gov_show_one -- viresh