From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932348AbcBHRcA (ORCPT ); Mon, 8 Feb 2016 12:32:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbcBHRb4 (ORCPT ); Mon, 8 Feb 2016 12:31:56 -0500 Date: Mon, 8 Feb 2016 11:31:54 -0600 From: Josh Poimboeuf To: Jessica Yu Cc: Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , Rusty Russell , Steven Rostedt , Ingo Molnar , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] ftrace/module: remove ftrace module notifier Message-ID: <20160208173154.GA23106@treble.redhat.com> References: <1454728097-7106-1-git-send-email-jeyu@redhat.com> <1454728097-7106-2-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1454728097-7106-2-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2016 at 10:08:16PM -0500, Jessica Yu wrote: > Remove the ftrace module notifier in favor of directly calling > ftrace_module_enable() and ftrace_release_mod() in the module loader. > Hard-coding the function calls directly in the module loader removes > dependence on the module notifier call chain and provides better > visibility and control over what gets called when, which is important > to kernel utilities such as livepatch. > > Signed-off-by: Jessica Yu This is also fixing the bug described in the cover letter, so it would be good to add a description of that here and a corresponding "Fixes:" tag. -- Josh