From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbcBHSN3 (ORCPT ); Mon, 8 Feb 2016 13:13:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:36027 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbcBHSN2 (ORCPT ); Mon, 8 Feb 2016 13:13:28 -0500 Date: Mon, 8 Feb 2016 19:13:26 +0100 From: Michal Marek To: Arnd Bergmann Cc: Michal Marek , linux-arm-kernel@lists.infradead.org, Mark Charlebois , Behan Webster , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Kbuild: provide a __UNIQUE_ID for clang Message-ID: <20160208181326.GA3784@pobox.suse.cz> References: <1454942318-2782493-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454942318-2782493-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 03:38:32PM +0100, Arnd Bergmann wrote: > The default __UNIQUE_ID macro in compiler.h fails to work for some drivers: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:615:1: error: redefinition of > '__UNIQUE_ID_firmware615' > BRCMF_FW_NVRAM_DEF(4354, "brcmfmac4354-sdio.bin", "brcmfmac4354-sdio.txt"); I applied the patch to kbuild.git#kbuild, but can you tell me with which commit and config you get such failure. I only see a single MODULE_FIRMWARE() call in the expansion of BRCMF_FW_NVRAM_DEF(), which should work with line numbers as well. And I can't reproduce it with today's linux-next. If there is some issue with code not yet in linux-next, it needs to be worked around, because older GCCs did not have __COUNTER__. Michal