From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755539AbcBHSpJ (ORCPT ); Mon, 8 Feb 2016 13:45:09 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:36067 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755285AbcBHSpD (ORCPT ); Mon, 8 Feb 2016 13:45:03 -0500 Date: Mon, 8 Feb 2016 10:44:56 -0800 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Matthew Garrett , Pali =?iso-8859-1?Q?Roh=E1r?= , Richard Purdie , Jacek Anaszewski , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request() Message-ID: <20160208184456.GM1779@malice.jf.intel.com> References: <1453472848-3118-1-git-send-email-kernel@kempniu.pl> <1453472848-3118-8-git-send-email-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453472848-3118-8-git-send-email-kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 03:27:19PM +0100, Michał Kępień wrote: > An SMBIOS buffer pointer does not need to be returned by > dell_smbios_send_request(), because SMBIOS call results are stored in > the buffer passed as input. This should come before 6/16, update the commit message to reflect the module exported buffer (not the one passed as input), or possibly just merge this patch and 6/16 as correcting the use of SMBIOS buffer within the module. -- Darren Hart Intel Open Source Technology Center