From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755915AbcBHU0v (ORCPT ); Mon, 8 Feb 2016 15:26:51 -0500 Received: from muru.com ([72.249.23.125]:60949 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755400AbcBHU0t (ORCPT ); Mon, 8 Feb 2016 15:26:49 -0500 Date: Mon, 8 Feb 2016 12:26:46 -0800 From: Tony Lindgren To: Ivaylo Dimitrov Cc: rogerq@ti.com, khilman@deeprootsystems.com, linux@arm.linux.org.uk, pali.rohar@gmail.com, sre@kernel.org, aaro.koskinen@iki.fi, pavel@ucw.cz, nm@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP2+: Fix onenand initialization to avoid filesystem corruption Message-ID: <20160208202646.GA19432@atomide.com> References: <1454683028-4193-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <20160208193644.GU19432@atomide.com> <56B8F71A.7090102@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B8F71A.7090102@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ivaylo Dimitrov [160208 12:15]: > Hi > > On 8.02.2016 21:36, Tony Lindgren wrote: > > > >OK. So probably the INT or RDY polarity made the ECC not work. > > > > Well, ECC disable bit (ONENAND_SYS_CFG1_NO_ECC) was set as well, so most > probably it was the bugger :) Oh OK that explains. > >Aaro, care to dump out also the nolo configured CFG1 value from > >n8x0 and n9(50)? > > > >You can do it by adding something like this to the beginning > >of set_onenand_cfg(): > > > > Also, do not forget to restore HWMOD_INIT_NO_RESET in gpmc_hwmod in question > and (maybe) revert e7b11dc7b77bfce0a351230a5feeadc1d0bba997. Probably just enabling CONFIG_OMAP_GPMC_DEBUG allows dumping the GPMC configuration. And it sounds like it's a good idea to have this patch enabled. Regards, Tony