From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756752AbcBHWFX (ORCPT ); Mon, 8 Feb 2016 17:05:23 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:55455 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756327AbcBHWFN (ORCPT ); Mon, 8 Feb 2016 17:05:13 -0500 Date: Mon, 8 Feb 2016 22:04:51 +0000 From: Luis Henriques To: Joe Perches Cc: Geoff Levand , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from Message-ID: <20160208220451.GA11603@charon.olymp> References: <1454866730-10481-1-git-send-email-luis.henriques@canonical.com> <1454866730-10481-2-git-send-email-luis.henriques@canonical.com> <1454869611.3739.8.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454869611.3739.8.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, Feb 07, 2016 at 10:26:51AM -0800, Joe Perches wrote: > On Sun, 2016-02-07 at 17:38 +0000, Luis Henriques wrote: > > Instead of defining a local version of struct ethhdr use the standard > > definition from . > > trivia: > > > diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c b/arch/powerpc/platforms/ps3/gelic_udbg.c > [] > > @@ -173,8 +169,8 @@ static void gelic_debug_init(void) > >   > >   h_eth = (struct ethhdr *)dbg.pkt; > >   > > - memset(&h_eth->dest, 0xff, 6); > > - memcpy(&h_eth->src, &mac, 6); > > + memset(&h_eth->h_dest, 0xff, 6); > > + memcpy(&h_eth->h_source, &mac, 6); > > Be nice to use ETH_ALEN and eth_broadcast_addr. > Maybe ether_addr_copy too. > > > @@ -183,7 +179,7 @@ static void gelic_debug_init(void) > >    GELIC_LV1_VLAN_TX_ETHERNET_0, 0, 0, > >    &vlan_id, &v2); > >   if (!result) { > > - h_eth->type = 0x8100; > > + h_eth->h_proto= 0x8100; > > ETH_P_8021Q > > >   header_size += sizeof(struct vlantag); > >   h_vlan = (struct vlantag *)(h_eth + 1); > > @@ -191,7 +187,7 @@ static void gelic_debug_init(void) > >   h_vlan->subtype = 0x0800; > >   h_ip = (struct iphdr *)(h_vlan + 1); > >   } else { > > - h_eth->type = 0x0800; > > + h_eth->h_proto= 0x0800; > > ETH_P_IP Great, I'll send out v2 that will include most of these comments. The one I'll leave out is the usage of ether_addr_copy. Thanks a lot for your comments. Cheers, -- Luís