From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Al Viro <viro@ZenIV.linux.org.uk>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 2/6] allow for per-symbol configurable EXPORT_SYMBOL()
Date: Mon, 8 Feb 2016 23:16:05 +0100 [thread overview]
Message-ID: <20160208221605.GB13832@ravnborg.org> (raw)
In-Reply-To: <1454963315-20468-3-git-send-email-nicolas.pitre@linaro.org>
On Mon, Feb 08, 2016 at 03:28:31PM -0500, Nicolas Pitre wrote:
> Similar to include/generated/autoconf.h, include/generated/expsyms.h will
> contain a list of defines for each EXPORT_SYMBOL() that we want active.
> The format is:
>
> #define __EXPSYM_<symbol_name> 1
Please spell it out.
EXP could be EXPECT...
> + $(Q)touch include/generated/expsyms.h
Same goes here. Make it explicit what this is about.
It is obvious today that "exp" is synonym for export_symbol.
But in one year less so.
Same goes for CONFIG_ symbol etc.
Sam
>
next prev parent reply other threads:[~2016-02-08 22:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 20:28 [PATCH 0/6] Trim unused exported symbols Nicolas Pitre
2016-02-08 20:28 ` [PATCH 1/6] kbuild: record needed exported symbols for modules Nicolas Pitre
2016-02-08 22:12 ` Sam Ravnborg
2016-02-08 22:28 ` Nicolas Pitre
2016-02-09 4:15 ` Al Viro
2016-02-09 4:36 ` Nicolas Pitre
2016-02-08 20:28 ` [PATCH 2/6] allow for per-symbol configurable EXPORT_SYMBOL() Nicolas Pitre
2016-02-08 22:16 ` Sam Ravnborg [this message]
2016-02-08 20:28 ` [PATCH 3/6] fixdep: minor cleanup Nicolas Pitre
2016-02-08 20:28 ` [PATCH 4/6] fixdep: add fine grained build dependencies for exported symbols Nicolas Pitre
2016-02-08 20:28 ` [PATCH 5/6] create/adjust generated/expsyms.h Nicolas Pitre
2016-02-08 22:24 ` Sam Ravnborg
2016-02-08 22:45 ` Nicolas Pitre
2016-02-08 20:28 ` [PATCH 6/6] kconfig option for TRIM_UNUSED_EXPSYMS Nicolas Pitre
2016-02-09 2:34 ` Rusty Russell
2016-02-09 4:30 ` Nicolas Pitre
2016-02-09 11:46 ` Sam Ravnborg
2016-02-09 13:28 ` Christoph Hellwig
2016-02-09 13:37 ` Austin S. Hemmelgarn
2016-02-09 17:04 ` Nicolas Pitre
2016-02-09 23:30 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208221605.GB13832@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.pitre@linaro.org \
--cc=rusty@rustcorp.com.au \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox