From: Stephen Boyd <sboyd@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/2] devm: add helper devm_add_action_or_reset()
Date: Mon, 8 Feb 2016 14:35:46 -0800 [thread overview]
Message-ID: <20160208223546.GA10791@codeaurora.org> (raw)
In-Reply-To: <1450873640-12489-1-git-send-email-sudipm.mukherjee@gmail.com>
On 12/23, Sudip Mukherjee wrote:
> Add a helper function devm_add_action_or_reset() which will internally
> call devm_add_action(). But if devm_add_action() fails then it will
> execute the action mentioned and return the error code.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
Greg, can I get your ack here to take this through clk-tree?
>
> Next patch of the series will use this helper. And from a first glance
> more use of this helper will be there.
>
> include/linux/device.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index f627ba2..f2455d0 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -682,6 +682,18 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res);
> int devm_add_action(struct device *dev, void (*action)(void *), void *data);
> void devm_remove_action(struct device *dev, void (*action)(void *), void *data);
>
> +static inline int devm_add_action_or_reset(struct device *dev,
> + void (*action)(void *), void *data)
> +{
> + int ret;
> +
> + ret = devm_add_action(dev, action, data);
> + if (ret)
> + action(data);
> +
> + return ret;
> +}
> +
> struct device_dma_parameters {
> /*
> * a low level driver may set these to teach IOMMU code about
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-08 22:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:27 [PATCH 1/2] devm: add helper devm_add_action_or_reset() Sudip Mukherjee
2015-12-23 12:27 ` [PATCH v2 2/2] clk: qcom: common: check for failure Sudip Mukherjee
2016-02-09 1:07 ` Stephen Boyd
2016-02-08 22:35 ` Stephen Boyd [this message]
2016-02-08 23:14 ` [PATCH 1/2] devm: add helper devm_add_action_or_reset() Greg Kroah-Hartman
2016-02-09 1:07 ` Stephen Boyd
2016-02-09 7:22 ` Sudip Mukherjee
2016-02-09 18:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208223546.GA10791@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).