From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932525AbcBIBHl (ORCPT ); Mon, 8 Feb 2016 20:07:41 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55686 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbcBIBHW (ORCPT ); Mon, 8 Feb 2016 20:07:22 -0500 Date: Mon, 8 Feb 2016 17:07:20 -0800 From: Stephen Boyd To: Sudip Mukherjee Cc: Michael Turquette , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-clk@vger.kernel.org Subject: Re: [PATCH v2 2/2] clk: qcom: common: check for failure Message-ID: <20160209010720.GJ10791@codeaurora.org> References: <1450873640-12489-1-git-send-email-sudipm.mukherjee@gmail.com> <1450873640-12489-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450873640-12489-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/23, Sudip Mukherjee wrote: > We were not checking the return from devm_add_action() which can fail. > Start using the helper and devm_add_action_or_reset() and return > directly as we know that the cleanup has been done by this helper. > > Signed-off-by: Sudip Mukherjee > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project