From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756453AbcBIDuk (ORCPT ); Mon, 8 Feb 2016 22:50:40 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35866 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755798AbcBIDui (ORCPT ); Mon, 8 Feb 2016 22:50:38 -0500 Date: Tue, 9 Feb 2016 09:20:35 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM list , Linux Kernel Mailing List Subject: Re: [PATCH] cpufreq: governor: Drop pointless goto from cpufreq_governor_init() Message-ID: <20160209035035.GB10843@vireshk> References: <121264863.5TXTuENuar@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <121264863.5TXTuENuar@vostro.rjw.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-02-16, 23:57, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > It is silly to jump around "return 0", so don't do that. > > Signed-off-by: Rafael J. Wysocki > --- > > On top of the bleeding-edge branch of linux-pm.git. > > Thanks, > Rafael > > --- > drivers/cpufreq/cpufreq_governor.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > Index: linux-pm/drivers/cpufreq/cpufreq_governor.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/cpufreq_governor.c > +++ linux-pm/drivers/cpufreq/cpufreq_governor.c > @@ -394,12 +394,11 @@ static int cpufreq_governor_init(struct > > ret = sysfs_create_group(get_governor_parent_kobj(policy), > get_sysfs_attr(gov)); > - if (ret) > - goto reset_gdbs_data; > + if (!ret) > + return 0; > > - return 0; > + /* Failure, so roll back. */ > > -reset_gdbs_data: > policy->governor_data = NULL; > > if (!have_governor_per_policy()) Acked-by: Viresh Kumar -- viresh