From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbcBIF1G (ORCPT ); Tue, 9 Feb 2016 00:27:06 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:55909 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbcBIF1E (ORCPT ); Tue, 9 Feb 2016 00:27:04 -0500 Date: Mon, 8 Feb 2016 22:26:55 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , stable@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Message-ID: <20160209052655.GA12657@obsidianresearch.com> References: <1454988630-27942-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454988630-27942-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > If the initialization fails before tpm_chip_register(), put_device() > will be not called, which causes release callback not to be called. > This patch fixes the issue by adding put_device() to devres list of > the parent device. Erm, if you do this, then shouldn't the device_unregister change to device_del to keep the kref balanced? Jason