From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755182AbcBIIdL (ORCPT ); Tue, 9 Feb 2016 03:33:11 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35229 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbcBIIdI (ORCPT ); Tue, 9 Feb 2016 03:33:08 -0500 Date: Tue, 9 Feb 2016 09:33:03 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Darren Hart Cc: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Matthew Garrett , Richard Purdie , Jacek Anaszewski , Alex Hung , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module Message-ID: <20160209083303.GN30075@pali> References: <1452607380-20861-1-git-send-email-kernel@kempniu.pl> <1452607380-20861-2-git-send-email-kernel@kempniu.pl> <20160116151922.GA5060@pali> <20160120092107.GA3247@eudyptula.hq.kempniu.pl> <20160121083559.GM7192@pali> <20160121130603.GA4360@eudyptula.hq.kempniu.pl> <20160121131450.GE7192@pali> <20160121133921.GA4626@eudyptula.hq.kempniu.pl> <20160208214210.GT1779@malice.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160208214210.GT1779@malice.jf.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 13:42:10 Darren Hart wrote: > Assuming the above is an accurate view, I don't see any reason to go beyond the > minimal change to the existing SMBIOS code to make it a usable API. If the need > arises, we can always make such optimizations and performance improvements > later. This is an internal API and we can change it whenever we need to so long > as we update the call sites. Problem is that now smbios code from dell-laptop.c is moved into dell-smbios.c and dell-smbios.h and LED subsystem starts using dell-smbios.h. In this case I'm thinking that we have something like API usable by other modules/subsystem. And I'm thinking if it is not better to create "correct" API now instead rewriting code in LED and platform subsystem again later... As this API needs to provide just 1 function, send command to Dell SMBIOS I think that API is still minimal. Currently we have another two functions alloc/free buffer (needed for send). -- Pali Rohár pali.rohar@gmail.com