From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755892AbcBIJPQ (ORCPT ); Tue, 9 Feb 2016 04:15:16 -0500 Received: from foss.arm.com ([217.140.101.70]:38762 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbcBIJPK (ORCPT ); Tue, 9 Feb 2016 04:15:10 -0500 Date: Tue, 9 Feb 2016 09:15:02 +0000 From: Brian Starkey To: Greg Kroah-Hartman Cc: Catalin Marinas , Dan Williams , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND2 PATCH 1/3] memremap: add MEMREMAP_WC flag Message-ID: <20160209091501.GA23507@e106950-lin.cambridge.arm.com> References: <9085d37fa97a762a46b9d58719c085368682c64f.1454950917.git.brian.starkey@arm.com> <20160208183006.GA8429@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160208183006.GA8429@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Mon, Feb 08, 2016 at 10:30:06AM -0800, Greg KH wrote: >On Mon, Feb 08, 2016 at 05:30:50PM +0000, Brian Starkey wrote: >> diff --git a/include/linux/io.h b/include/linux/io.h >> index 32403b5..e2c8419 100644 >> --- a/include/linux/io.h >> +++ b/include/linux/io.h >> @@ -135,6 +135,7 @@ enum { >> /* See memremap() kernel-doc for usage description... */ >> MEMREMAP_WB = 1 << 0, >> MEMREMAP_WT = 1 << 1, >> + MEMREMAP_WC = 1 << 2, > >You didn't update the documentation :( > Maybe I missed something, but I don't think there's anything to update here? Like the comment says, the flags are documented in the memremap() kernel-doc (which I did update - see the next two hunks of this patch). Thanks, Brian