From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756007AbcBIJWB (ORCPT ); Tue, 9 Feb 2016 04:22:01 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34012 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbcBIJV5 (ORCPT ); Tue, 9 Feb 2016 04:21:57 -0500 Date: Tue, 9 Feb 2016 10:22:20 +0100 From: Daniel Vetter To: Insu Yun Cc: airlied@linux.ie, daniel.vetter@ffwll.ch, ville.syrjala@linux.intel.com, alexander.deucher@amd.com, treding@nvidia.com, boris.brezillon@free-electrons.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [PATCH] ch7006: correctly handling failed allocation Message-ID: <20160209092220.GC11240@phenom.ffwll.local> Mail-Followup-To: Insu Yun , airlied@linux.ie, ville.syrjala@linux.intel.com, alexander.deucher@amd.com, treding@nvidia.com, boris.brezillon@free-electrons.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu References: <1454025276-13465-1-git-send-email-wuninsu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454025276-13465-1-git-send-email-wuninsu@gmail.com> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 06:54:36PM -0500, Insu Yun wrote: > Since drm_property_create_range can be failed in memory pressure, > it needs to be checked and return -ENOMEM. > > Signed-off-by: Insu Yun Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c > index 90db5f4..0594c45 100644 > --- a/drivers/gpu/drm/i2c/ch7006_drv.c > +++ b/drivers/gpu/drm/i2c/ch7006_drv.c > @@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder, > drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names); > > priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2); > + if (!priv->scale_property) > + return -ENOMEM; > > drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property, > priv->select_subconnector); > -- > 1.9.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch