From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756619AbcBIJwx (ORCPT ); Tue, 9 Feb 2016 04:52:53 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34032 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbcBIJwt (ORCPT ); Tue, 9 Feb 2016 04:52:49 -0500 Date: Tue, 9 Feb 2016 10:52:45 +0100 From: Ingo Molnar To: Joe Perches Cc: Chen Yucong , tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 1/2] printk: introduce pr_default() macro Message-ID: <20160209095245.GA3177@gmail.com> References: <1454680092-30523-1-git-send-email-slaoub@gmail.com> <1454688895.3263.17.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454688895.3263.17.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Joe Perches wrote: > On Fri, 2016-02-05 at 21:48 +0800, Chen Yucong wrote: > > Until now, we cover all log-levels by pr_  macros except > > KERN_DEFAULT one. Add it for convenience. > > I'd rather it be removed altogether. Yes, they should be converted to KERN_WARNING (which is the default loglevel), and another patch should remove KERN_DEFAULT altogether. Thanks, Ingo