From: Ingo Molnar <mingo@kernel.org>
To: Chen Yucong <slaoub@gmail.com>
Cc: tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/kernel: use pr_<level>() and dev_<level>
Date: Tue, 9 Feb 2016 10:57:49 +0100 [thread overview]
Message-ID: <20160209095749.GA2953@gmail.com> (raw)
In-Reply-To: <1454666121-14972-1-git-send-email-slaoub@gmail.com>
* Chen Yucong <slaoub@gmail.com> wrote:
> arch/x86/kernel/* use a mixture of printk(KERN_<level> ) and pr_<level>().
> This patch converts the bulk of printk(KERN_<level> ) to pr_<level>() and
> uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning()
> calls have been replaced with pr_warn().
>
> Not sure what to do about the printk(KERN_DEFAULT) and printk() without a
> log level.
>
> Signed-off-by: Chen Yucong <slaoub@gmail.com>
When converting please also join broken up format strings, such as:
- printk(KERN_WARNING PREFIX
- "HPET id: %#x base: 0xfed0000000000000 fixed up "
- "to 0xfed00000.\n", hpet_tbl->id);
+ pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up "
+ "to 0xfed00000.\n", hpet_tbl->id);
ignore checkpatch: we don't line-break user visible strings.
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-09 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 9:55 [PATCH] x86/kernel: use pr_<level>() and dev_<level> Chen Yucong
2016-02-09 9:57 ` Ingo Molnar [this message]
2016-02-09 10:52 ` Thomas Gleixner
2016-02-09 23:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209095749.GA2953@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=slaoub@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).