From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353AbcBIJ55 (ORCPT ); Tue, 9 Feb 2016 04:57:57 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34885 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbcBIJ5x (ORCPT ); Tue, 9 Feb 2016 04:57:53 -0500 Date: Tue, 9 Feb 2016 10:57:49 +0100 From: Ingo Molnar To: Chen Yucong Cc: tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/kernel: use pr_() and dev_ Message-ID: <20160209095749.GA2953@gmail.com> References: <1454666121-14972-1-git-send-email-slaoub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454666121-14972-1-git-send-email-slaoub@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Chen Yucong wrote: > arch/x86/kernel/* use a mixture of printk(KERN_ ) and pr_(). > This patch converts the bulk of printk(KERN_ ) to pr_() and > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning() > calls have been replaced with pr_warn(). > > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a > log level. > > Signed-off-by: Chen Yucong When converting please also join broken up format strings, such as: - printk(KERN_WARNING PREFIX - "HPET id: %#x base: 0xfed0000000000000 fixed up " - "to 0xfed00000.\n", hpet_tbl->id); + pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up " + "to 0xfed00000.\n", hpet_tbl->id); ignore checkpatch: we don't line-break user visible strings. Thanks, Ingo