From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933095AbcBIL1h (ORCPT ); Tue, 9 Feb 2016 06:27:37 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35117 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932974AbcBIL1g (ORCPT ); Tue, 9 Feb 2016 06:27:36 -0500 Date: Tue, 9 Feb 2016 12:27:32 +0100 From: Ingo Molnar To: Borislav Petkov Cc: Toshi Kani , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, dan.j.williams@intel.com, ross.zwisler@linux.intel.com, vishal.l.verma@intel.com, micah.parrish@hpe.com, brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy Message-ID: <20160209112732.GB500@gmail.com> References: <1454524511-29416-1-git-send-email-toshi.kani@hpe.com> <20160209102741.GA11313@gmail.com> <20160209111404.GA4434@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160209111404.GA4434@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Tue, Feb 09, 2016 at 11:27:41AM +0100, Ingo Molnar wrote: > > So another pet peeve of mine is to not use numeric labels, please use > > descriptively named labels instead. > > ... and prepend them with ".L" so that they become local labels. Yes. A good example to follow would be arch/x86/entry/entry_64.S. Btw., IIRC GAS is being silly about .L, i.e. there's a difference between these two variants: .Lerror_entry_from_usermode_swapgs: .L_error_entry_from_usermode_swapgs: the latter would be easier to read, but does not result in a local label last I checked. Right? Thanks, Ingo