From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754970AbcBILfs (ORCPT ); Tue, 9 Feb 2016 06:35:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:51218 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbcBILfq (ORCPT ); Tue, 9 Feb 2016 06:35:46 -0500 Date: Tue, 9 Feb 2016 12:35:43 +0100 From: Johannes Thumshirn To: Dan Carpenter Cc: Alasdair Kergon , Mike Snitzer , linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org, dm-devel@redhat.com, Shaohua Li , linux-kernel@vger.kernel.org Subject: Re: [dm-devel] [patch] dm: check for kmalloc failure in dm_init_request_based_blk_mq_queue() Message-ID: <20160209113543.GL27969@c203.arch.suse.de> References: <20160209111440.GB23998@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160209111440.GB23998@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2016 at 02:14:40PM +0300, Dan Carpenter wrote: > We can just return -ENOMEM if the kzalloc() fails. > > Fixes: 41b2facaf4ba ('dm: allocate blk_mq_tag_set rather than embed in mapped_device') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/md/dm.c b/drivers/md/dm.c > index 6b7e80e..1a5f879 100644 > --- a/drivers/md/dm.c > +++ b/drivers/md/dm.c > @@ -2736,6 +2736,8 @@ static int dm_init_request_based_blk_mq_queue(struct mapped_device *md, > int err; > > md->tag_set = kzalloc(sizeof(struct blk_mq_tag_set), GFP_KERNEL); > + if (!md->tag_set) > + return -ENOMEM; > md->tag_set->ops = &dm_mq_ops; > md->tag_set->queue_depth = dm_get_blk_mq_queue_depth(); > md->tag_set->numa_node = NUMA_NO_NODE; > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel Good catch, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850