From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754761AbcBIMKH (ORCPT ); Tue, 9 Feb 2016 07:10:07 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36414 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbcBIMKF (ORCPT ); Tue, 9 Feb 2016 07:10:05 -0500 Date: Tue, 9 Feb 2016 13:10:00 +0100 From: Mathieu OTHACEHE To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Kalle Valo , Joe Perches , gnomes@lxorguk.ukuu.org.uk, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] tty: add Moxa Smartio MUE serial driver Message-ID: <20160209121000.GA3136@gmail.com> References: <1454358859-5534-1-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In > which case why not to use 8250_core.c / 8250_port.c and entire 8250/ > infrastructure? Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie. The mxser driver has been cleaned up and integrated to mainline a long time ago (drivers/tty/mxser.c). I'm trying to do the same thing with the mxupcie driver. mxser and mxupcie are quite similar, maybe both should use 8250 infrastructure and not have independant drivers ? Mathieu