From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932620AbcBIPTD (ORCPT ); Tue, 9 Feb 2016 10:19:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754609AbcBIPTA (ORCPT ); Tue, 9 Feb 2016 10:19:00 -0500 Date: Tue, 9 Feb 2016 16:18:56 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence Message-ID: <20160209151856.GA16208@potion.brq.redhat.com> References: <1454948146-35353-1-git-send-email-pbonzini@redhat.com> <1454948146-35353-2-git-send-email-pbonzini@redhat.com> <20160209135502.GA30378@potion.brq.redhat.com> <56BA0069.30606@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56BA0069.30606@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-02-09 16:06+0100, Paolo Bonzini: > On 09/02/2016 14:55, Radim Krčmář wrote: >> This is most likely going to bug on the following path: >> handle_apic_access -> kvm_lapic_set_eoi >> >> Before the change, handle_apic_access would just drop EOIs that should >> have gone to user space ... I'm not sure if we tested it, or the path is >> really never taken. > > cpu_need_virtualize_apic_accesses is needed to set > SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES (vmx_secondary_exec_control) and > SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES is required to get to > handle_apic_access. Thanks, Reviewed-by: Radim Krčmář