From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756973AbcBISSh (ORCPT ); Tue, 9 Feb 2016 13:18:37 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49475 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756807AbcBISSf (ORCPT ); Tue, 9 Feb 2016 13:18:35 -0500 Date: Tue, 9 Feb 2016 10:18:33 -0800 From: Stephen Boyd To: Dinh Nguyen Cc: Vladimir Zapolskiy , Michael Turquette , linux-clk@vger.kernel.org, linux-kernel , Masahiro Yamada Subject: Re: commit 5146e0b05963 is causing a kernel crash on SoCFPGA Message-ID: <20160209181833.GA24167@codeaurora.org> References: <56B9507B.9000201@kernel.org> <56B9BB41.3080001@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09, Masahiro Yamada wrote: > 2016-02-09 19:11 GMT+09:00 Dinh Nguyen : > > > > > Yes, .get_parent call back is define when num_parents = 1. If you take a > > look at socfpga.dtsi, the main_pll of type "altr,socfpga-pll-clk" only > > has 1 parent, osc1. But the periph_pll and sdram_pll, also of type > > "altr,socfpga-pll-clk" has > 1 parents. > > > OK. Then, I understood the cause of the problem. > The patch looks good as an optimization but is there also going to be a fix for the socfpga code? It looks like we've exposed a bug in the implementation there. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project