From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755100AbcBIXi7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 18:38:59 -0500
Received: from mga03.intel.com ([134.134.136.65]:15639 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753107AbcBIXi6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 18:38:58 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,423,1449561600"; 
   d="scan'208";a="45270350"
Date: Tue, 9 Feb 2016 15:38:57 -0800
From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>, elliott@hpe.com,
        Brian Gerst <brgerst@gmail.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-nvdimm@ml01.01.org, x86@kernel.org
Subject: Re: [PATCH v10 4/4] x86: Create a new synthetic cpu capability for
 machine check recovery
Message-ID: <20160209233857.GA24348@agluck-desk.sc.intel.com>
References: <cover.1454618190.git.tony.luck@intel.com>
 <97426a50c5667bb81a28340b820b371d7fadb6fa.1454618190.git.tony.luck@intel.com>
 <20160207171041.GG5862@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160207171041.GG5862@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +	if (mca_cfg.recovery || (mca_cfg.ser &&
> > +		!strncmp(c->x86_model_id, "Intel(R) Xeon(R) CPU E7-", 24)))
> 
> Eeww, a model string check :-(
> 
> Lemme guess: those E7s can't be represented by a range of
> model/steppings, can they?

We use the same model number for E5 and E7 series. E.g. 63 for Haswell.
The model_id string seems to be the only way to tell ahead of time
whether you will get a recoverable machine check or die when you
touch uncorrected memory.

-Tony