From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbcBJFMj (ORCPT ); Wed, 10 Feb 2016 00:12:39 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35103 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbcBJFMh (ORCPT ); Wed, 10 Feb 2016 00:12:37 -0500 Date: Wed, 10 Feb 2016 10:42:27 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Benjamin Romer , David Kershner , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v2] staging: unisys: use common return path Message-ID: <20160210051227.GA27755@sudip-pc> References: <1448967153-14537-1-git-send-email-sudipm.mukherjee@gmail.com> <20160207220421.GB28175@kroah.com> <20160208171657.GB17609@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160208171657.GB17609@sudip-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 10:46:57PM +0530, Sudip Mukherjee wrote: > On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote: > > On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote: > > > The success path and the error path both are first doing > > > spin_unlock_irqrestore() before returning. Use that in the common path > > > and return the success/error value. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > > > > v2: changed label name > > > > > > It is dependent on the patch series sent by Benjamin (Nov 30th). > > > > Which didn't get applied, so can you resend this after that does get > > accepted? > > oops, i dont think i have the patch anymore. But looking at the commit > message, i think i just sent the same suggestion to Benjamin for his > [PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c > > If he is not changing then I will create the patch and send you. Hi Greg, I will not be resending this patch as Ben is against to using goto. regards sudip