* [PATCH] EDAC: Use edac_debugfs_remove_recursive() in edac_debugfs_exit()
@ 2016-02-10 0:29 tthayer
2016-02-10 10:02 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: tthayer @ 2016-02-10 0:29 UTC (permalink / raw)
To: bp, dougthompson, m.chehab; +Cc: linux-edac, linux-kernel, tthayer
From: Thor Thayer <tthayer@opensource.altera.com>
debugfs_remove() is used to remove a file or a directory from the
debugfs filesystem on an EDAC device exit. However edac_debugfs
might not be empty. This is similar to another patch [1] that
changed the EDAC MCI code to use edac_debugfs_remove_recursive().
[1] https://lkml.org/lkml/2015/10/13/974
Suggested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
---
---
drivers/edac/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/debugfs.c b/drivers/edac/debugfs.c
index 54d2f66..92dbb7e 100644
--- a/drivers/edac/debugfs.c
+++ b/drivers/edac/debugfs.c
@@ -53,7 +53,7 @@ int __init edac_debugfs_init(void)
void edac_debugfs_exit(void)
{
- debugfs_remove(edac_debugfs);
+ debugfs_remove_recursive(edac_debugfs);
}
int edac_create_debugfs_nodes(struct mem_ctl_info *mci)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC: Use edac_debugfs_remove_recursive() in edac_debugfs_exit()
2016-02-10 0:29 [PATCH] EDAC: Use edac_debugfs_remove_recursive() in edac_debugfs_exit() tthayer
@ 2016-02-10 10:02 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2016-02-10 10:02 UTC (permalink / raw)
To: tthayer; +Cc: dougthompson, m.chehab, linux-edac, linux-kernel
On Tue, Feb 09, 2016 at 06:29:25PM -0600, tthayer@opensource.altera.com wrote:
> From: Thor Thayer <tthayer@opensource.altera.com>
>
> debugfs_remove() is used to remove a file or a directory from the
> debugfs filesystem on an EDAC device exit. However edac_debugfs
> might not be empty. This is similar to another patch [1] that
> changed the EDAC MCI code to use edac_debugfs_remove_recursive().
>
> [1] https://lkml.org/lkml/2015/10/13/974
>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
Applied, thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-10 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 0:29 [PATCH] EDAC: Use edac_debugfs_remove_recursive() in edac_debugfs_exit() tthayer
2016-02-10 10:02 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).