From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sanchayan Maity <maitysanchayan@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-testers@vger.kernel.org,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: colibri-vf50-ts: fix implicit declaration
Date: Wed, 10 Feb 2016 15:34:16 +0530 [thread overview]
Message-ID: <20160210100416.GA8872@sudip-pc> (raw)
In-Reply-To: <CAMuHMdVViFX+0Wi_LBFsjFStEZnX1XNG-n8tj6qug3mSioySag@mail.gmail.com>
On Wed, Feb 10, 2016 at 10:54:45AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 10, 2016 at 10:45 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > The build of m32r allmodconfig fails with the error:
> > drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit
> > declaration of function 'of_property_read_u32'
> >
> > of_property_read_u32() is defined in linux/of.h which was not included.
> >
> > Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB")
>
> Actually I had sent the exact same patch to add this missing include,
> to apply before 1261d013daea, but it seems Dmitry only applied the
> second one.
>
> http://permalink.gmane.org/gmane.linux.kernel.gpio/14086
apart from m32r it also affects tilegx, s390, m68k allmodconfig.
I hope Dmitry applies any one from your or mine patch today.
regards
sudip
prev parent reply other threads:[~2016-02-10 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:45 [PATCH] Input: colibri-vf50-ts: fix implicit declaration Sudip Mukherjee
2016-02-10 9:54 ` Geert Uytterhoeven
2016-02-10 10:04 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210100416.GA8872@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).