From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757686AbcBJKEb (ORCPT ); Wed, 10 Feb 2016 05:04:31 -0500 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35745 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757646AbcBJKEZ (ORCPT ); Wed, 10 Feb 2016 05:04:25 -0500 Date: Wed, 10 Feb 2016 15:34:16 +0530 From: Sudip Mukherjee To: Geert Uytterhoeven Cc: Dmitry Torokhov , Sanchayan Maity , "linux-kernel@vger.kernel.org" , kernel-testers@vger.kernel.org, "linux-input@vger.kernel.org" Subject: Re: [PATCH] Input: colibri-vf50-ts: fix implicit declaration Message-ID: <20160210100416.GA8872@sudip-pc> References: <1455097547-31053-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 10:54:45AM +0100, Geert Uytterhoeven wrote: > On Wed, Feb 10, 2016 at 10:45 AM, Sudip Mukherjee > wrote: > > The build of m32r allmodconfig fails with the error: > > drivers/input/touchscreen/colibri-vf50-ts.c:302:10: error: implicit > > declaration of function 'of_property_read_u32' > > > > of_property_read_u32() is defined in linux/of.h which was not included. > > > > Fixes: 1261d013daea ("Input: Allow compile test of Goodix and Colibri VF50 if !GPIOLIB") > > Actually I had sent the exact same patch to add this missing include, > to apply before 1261d013daea, but it seems Dmitry only applied the > second one. > > http://permalink.gmane.org/gmane.linux.kernel.gpio/14086 apart from m32r it also affects tilegx, s390, m68k allmodconfig. I hope Dmitry applies any one from your or mine patch today. regards sudip