From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbcBJNXl (ORCPT ); Wed, 10 Feb 2016 08:23:41 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35280 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbcBJNXh (ORCPT ); Wed, 10 Feb 2016 08:23:37 -0500 Date: Wed, 10 Feb 2016 13:23:33 +0000 From: Lee Jones To: Laxman Dewangan Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com, vreddytalla@nvidia.com Subject: Re: [PATCH V7 1/8] mfd: add device-tree binding doc for PMIC max77620/max20024 Message-ID: <20160210132333.GG24522@x1> References: <1454171931-27752-1-git-send-email-ldewangan@nvidia.com> <1454171931-27752-2-git-send-email-ldewangan@nvidia.com> <20160209154215.GF24522@x1> <56BA2859.2040605@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56BA2859.2040605@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Feb 2016, Laxman Dewangan wrote: > > On Tuesday 09 February 2016 09:12 PM, Lee Jones wrote: > >On Sat, 30 Jan 2016, Laxman Dewangan wrote: > > > >+ Normal mode also called as active mode on which all step-down > >+ regulators, all linear regulators, GPIOs, and the 32kHz > >+ oscillator are in normal active mode. > >+ sleep mode: Regulators/GPIOs/clock can go on OFF state based on > >"can go on OFF state"? > > Regulator/GPIO has two states, enable and disable. If sleep mode is > configured for these resource and external signal triggers to sleep > then this get disabled. It's the English that I'm unhappy with. "can go on OFF state" doesn't sound right. > >>+ source gets the control signal for ON and OFF. > >>+ Power on slot: Slot number on which resource is ON once FPS source > >>+ get ON signal. > >Can you find another way of explaining this please? > > Hmm.. > Does it look fine: > There is 8 slots for each FPS on which resource can get enabled. > This property provides the slot number on which resource gets > enabled after FPS sequence started. It's a bit better, yes. Although it's still a little difficult to read. In fact, I can't even recommend a suitable alternative, since I still do not understand exactly what it is you're trying to say. > >+ > >+-maxim,enable-sleep: Boolean, enable sleep state of PMIC > >We already have bindings for sleeping. Please use a generic one. > > Which property? Saw sleep property with vendor prefix. I guess there are too many '.*sleep.*' properties now, each with slightly different syntax and meaning. The situation is exacerbated by one of the key examples is using the property with cells expected i.e. non-bool. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog