From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752713AbcBJQgp (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 11:36:45 -0500
Received: from mail-ig0-f195.google.com ([209.85.213.195]:36595 "EHLO
	mail-ig0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751662AbcBJQgm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 11:36:42 -0500
Date: Wed, 10 Feb 2016 10:36:22 -0600
From: Michael Welling <mwelling@ieee.org>
To: Sricharan <sricharan@codeaurora.org>
Cc: "'Daniel Baluta'" <daniel.baluta@intel.com>,
        "'Wolfram Sang'" <wsa@the-dreams.de>,
        "'Jonathan Cameron'" <jic23@kernel.org>,
        "'Hartmut Knaack'" <knaack.h@gmx.de>,
        "'Lars-Peter Clausen'" <lars@metafoo.de>,
        "'Peter Meerwald-Stadler'" <pmeerw@pmeerw.net>,
        "'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>,
        linux-iio@vger.kernel.org,
        "'Lucas De Marchi'" <lucas.demarchi@intel.com>,
        "'Andy Gross'" <agross@codeaurora.org>,
        "'Pramod Gurav'" <pramod.gurav@smartplayin.com>,
        "'Bjorn Andersson'" <bjorn.andersson@sonymobile.com>,
        "'Guenter Roeck'" <linux@roeck-us.net>, eibach@gdsys.de,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support
Message-ID: <20160210163622.GA1390@deathstar>
References: <20160205172457.GA16778@deathstar>
 <CAEnQRZAjgn3Y0618MgO284DMc_9cE49b9jeUr0j2HwUK6YK+0A@mail.gmail.com>
 <20160206003245.GA1329@deathstar>
 <20160208102459.GC2220@tetsubishi>
 <20160208163632.GA3630@deathstar>
 <01fd01d162a4$8e28c450$aa7a4cf0$@codeaurora.org>
 <20160208191658.GA23145@deathstar>
 <001b01d163fd$bfb15280$3f13f780$@codeaurora.org>
 <CAEnQRZCzkq5wFsS7Ydby+bsFJTbGVq=AX9TLkkhfMKOG8gAZHA@mail.gmail.com>
 <003201d16415$0eb1a8f0$2c14fad0$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <003201d16415$0eb1a8f0$2c14fad0$@codeaurora.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote:
> > Hi Sricharan,
> > 
> > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c
> > right?
> >
>  Yes.
>  
> > I'm asking this because this driver doesn't seem to support runtime pm and
> > there is no check for regmap_write/regmap_write return code in the probe
> > function.
>    Hmm to be clear, so it’s the pm_runtime_getsync from i2c-qup which fails right ?
>    I was tracking that when there are i2c_xfers from pwm. I did not see any failures there.
>    So wanted to know the correct sequence to reproduce.
>

The problem was discovered using the patch that this thread is on. The PWM driver does
not have the problem.

When the driver in this patch called pm_runtime_get_sync you got -EINVAL back.

> Regards,
>   Sricharan
>   
> 
>