From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980AbcBJRBd (ORCPT ); Wed, 10 Feb 2016 12:01:33 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37461 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbcBJRBb (ORCPT ); Wed, 10 Feb 2016 12:01:31 -0500 Date: Wed, 10 Feb 2016 17:01:27 +0000 From: Lee Jones To: John Crispin Cc: Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH V3 1/4] dt-bindings: mfd: Add bindings for the MediaTek MT6323 PMIC Message-ID: <20160210170127.GW3782@x1> References: <1453895258-44369-1-git-send-email-blogic@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453895258-44369-1-git-send-email-blogic@openwrt.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If you're submitting a set of patches like this, you really ought to be providing a cover-letter. Also, when submitting patches, please do so in the style expected by the subsystem. I will fix these once up for now, but please bear that in mind in the future. `git log --oneline -- ` works well for this. > Signed-off-by: John Crispin > Cc: devicetree@vger.kernel.org > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 15043e6..949c85f 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -1,6 +1,6 @@ > -MediaTek MT6397 Multifunction Device Driver > +MediaTek MT6397/MT6323 Multifunction Device Driver > > -MT6397 is a multifunction device with the following sub modules: > +MT6397/MT6323 is a multifunction device with the following sub modules: > - Regulator > - RTC > - Audio codec > @@ -8,14 +8,14 @@ MT6397 is a multifunction device with the following sub modules: > - Clock > > It is interfaced to host controller using SPI interface by a proprietary hardware > -called PMIC wrapper or pwrap. MT6397 MFD is a child device of pwrap. > +called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. > See the following for pwarp node definitions: > Documentation/devicetree/bindings/soc/pwrap.txt > > This document describes the binding for MFD device and its sub module. > > Required properties: > -compatible: "mediatek,mt6397" > +compatible: "mediatek,mt6397" or "mediatek,mt6323" > > Optional subnodes: > > @@ -26,6 +26,8 @@ Optional subnodes: > Required properties: > - compatible: "mediatek,mt6397-regulator" > see Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > + - compatible: "mediatek,mt6323-regulator" > + see Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > - codec > Required properties: > - compatible: "mediatek,mt6397-codec" -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog