From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbcBJRVq (ORCPT ); Wed, 10 Feb 2016 12:21:46 -0500 Received: from mx1.mailbox.org ([80.241.60.212]:46714 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510AbcBJRVo (ORCPT ); Wed, 10 Feb 2016 12:21:44 -0500 X-Greylist: delayed 552 seconds by postgrey-1.27 at vger.kernel.org; Wed, 10 Feb 2016 12:21:44 EST Date: Wed, 10 Feb 2016 18:12:24 +0100 From: Christian Brauner To: Greg KH Cc: tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] let kernfs_name_locked & kernfs_name return size_t Message-ID: <20160210171224.GA5261@mailbox.org> References: <1455121139-4026-1-git-send-email-christian.brauner@mailbox.org> <1455121139-4026-2-git-send-email-christian.brauner@mailbox.org> <20160210165314.GA27721@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160210165314.GA27721@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 08:53:14AM -0800, Greg KH wrote: > On Wed, Feb 10, 2016 at 05:18:59PM +0100, Christian Brauner wrote: > > They return the length of kn->parent or kn->name and should be aligned with > > kernfs_path_len which also returns size_t. > > > > Signed-off-by: Christian Brauner > > --- > > fs/kernfs/dir.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > > index 742bf4a..a3553b8 100644 > > --- a/fs/kernfs/dir.c > > +++ b/fs/kernfs/dir.c > > @@ -39,7 +39,7 @@ static bool kernfs_lockdep(struct kernfs_node *kn) > > #endif > > } > > > > -static int kernfs_name_locked(struct kernfs_node *kn, char *buf, size_t buflen) > > +static size_t kernfs_name_locked(struct kernfs_node *kn, char *buf, size_t buflen) > > { > > return strlcpy(buf, kn->parent ? kn->name : "/", buflen); > > } > > @@ -80,7 +80,7 @@ static char * __must_check kernfs_path_locked(struct kernfs_node *kn, char *buf, > > * > > * This function can be called from any context. > > */ > > -int kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen) > > +size_t kernfs_name(struct kernfs_node *kn, char *buf, size_t buflen) > > { > > unsigned long flags; > > int ret; > > Now if only you had test built this patch :( I actually did but forgot to commit the changes to include/linux/kernfs.h as well. > > Please be more careful, it just makes maintainers grumpy and annoyed > when you do that... Yes, sorry. I will do that. I'll resend with the appropriate changes to kernfs.h included. Thanks for being patient.