From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbcBJSvw (ORCPT ); Wed, 10 Feb 2016 13:51:52 -0500 Received: from mail.skyhub.de ([78.46.96.112]:34244 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbcBJSvv (ORCPT ); Wed, 10 Feb 2016 13:51:51 -0500 Date: Wed, 10 Feb 2016 19:51:46 +0100 From: Borislav Petkov To: Suravee Suthikulpanit Cc: joro@8bytes.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Message-ID: <20160210185146.GA11024@pd.tnic> References: <1455058435-8716-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1455058435-8716-2-git-send-email-Suravee.Suthikulpanit@amd.com> <20160210164116.GG23914@pd.tnic> <56BB84AC.5080605@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56BB84AC.5080605@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 01:42:52AM +0700, Suravee Suthikulpanit wrote: > The reason I picked this location to place the header file is because > there is already an existing include/linux/perf/arm_pmu.h file there. I don't think anything arch-specific belongs in generic kernel header paths. > So, I thought it might be alright to put the perf_event_amd_iommu.h > here. > > Having the information in the file arch/x86/events/amd/iommu.h seems > strange for having to specify ../../arch/x86/events/amd/iommu.h in the > IOMMU driver. > > So, you think it would be alright if move > > include/linux/perf/perf_event_amd_iommu.h > to > arch/x86/include/perf/perf_event_amd_iommu.h If it feels strange to you, you can move it to arch/x86/include/asm/ There we put the arch-specific stuff. Then you can do #include or so. I've moved it to arch/x86/events/amd/iommu.h already anyway. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.