From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbcBKIE4 (ORCPT ); Thu, 11 Feb 2016 03:04:56 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33566 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcBKIEz (ORCPT ); Thu, 11 Feb 2016 03:04:55 -0500 Date: Thu, 11 Feb 2016 17:03:03 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Andrew Morton , Jan Kara , Tejun Heo , Kyle McMartin , Dave Jones , Calvin Owens , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [RFC][PATCH v3 2/4] printk: do not console_cont_flush() on every jump to again Message-ID: <20160211080303.GB895@swordfish> References: <1453536913-9545-1-git-send-email-sergey.senozhatsky@gmail.com> <1453536913-9545-3-git-send-email-sergey.senozhatsky@gmail.com> <20160210165833.GH12548@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160210165833.GH12548@pathway.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Petr, On (02/10/16 17:58), Petr Mladek wrote: > On Sat 2016-01-23 17:15:11, Sergey Senozhatsky wrote: > > Every jump to `again' label will call console_cont_flush(), > > which is not really something big -- it just adds one extra > > raw_spin_lock_irqsave/raw_spin_unlock_irqrestore. However, to > > keep the previous behaviour we can call console_cont_flush() > > only when `retry' is false -- which happens once, all jumps > > to `again' label have `retry' set to true. > > The patch is correct and restores the original behavior, so > > Reviewed-by: Petr Mladek > > But I would personally omit it. We see the cont buffer earlier > without this patch. ok. > PS: I will review the other patches tomorrow. thanks. -ss