From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbcBKJRj (ORCPT ); Thu, 11 Feb 2016 04:17:39 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38347 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbcBKJRf (ORCPT ); Thu, 11 Feb 2016 04:17:35 -0500 Date: Thu, 11 Feb 2016 09:17:31 +0000 From: Lee Jones To: "Opensource [Steve Twiss]" Cc: LINUXKERNEL Subject: Re: [PATCH V1] mfd: da9062: fix missing volatile registers in the core regmap_range volatile lists Message-ID: <20160211091731.GD3782@x1> References: <20160201161049.7F7953FB84@swsrvapps-01.diasemi.com> <20160210165603.GR3782@x1> <6ED8E3B22081A4459DAC7699F3695FB70173D30C81@SW-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB70173D30C81@SW-EX-MBX02.diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2016, Opensource [Steve Twiss] wrote: > > On 10 February 2016 16:56, Lee Jones wrote: > > > To: Opensource [Steve Twiss] > > Cc: LINUXKERNEL; David Dajun Chen; Support Opensource > > Subject: Re: [PATCH V1] mfd: da9062: fix missing volatile registers in the core > > regmap_range volatile lists > > > > On Mon, 01 Feb 2016, Steve Twiss wrote: > > > > > From: Steve Twiss > > > > > > Add an updated set of registers listed in the core regmap_range volatile > > > ranges defined for the DA9062. > > > > > > These new registers contain bits that cannot be considered under the full > > > control of software. Under various conditions the hardware will set and/or > > > automatically clear bit(s) contained in these registers. > > > > > > When using a cached version of regmap, the volatility of these registers must > > > be identified otherwise the regmap operations may not ensure the registers > > > are explicitly altered. > > > > > > As well as updating the list of volatile registers, this change will fix a > > > corner case discovered in the DA9063 ONKEY which is used by the DA9062 core. > > > > > > In the ONKEY case, the CONTROL_B register is now listed as volatile in the > > > regmap_range because it contains the bit field NONKEY_LOCK. This bit can be > > > altered by hardware, in which case regmap must be notified of its ability > > > to be manpiulated outside of software control. > > > > > > Signed-off-by: Steve Twiss > > > > Applied, thanks. > > Thanks. > Regards, > Steve No need for thank yous. They're implied. ;) [... and they just account for churn in my already very busy inbox]. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog