From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbcBKKtA (ORCPT ); Thu, 11 Feb 2016 05:49:00 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33814 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbcBKKs6 (ORCPT ); Thu, 11 Feb 2016 05:48:58 -0500 Date: Thu, 11 Feb 2016 11:49:21 +0100 From: Daniel Vetter To: Arnd Bergmann Cc: Daniel Vetter , David Airlie , linux-arm-kernel@lists.infradead.org, Rob Clark , David Herrmann , =?iso-8859-1?Q?St=E9phane?= Marchesin , Haixia Shi , Archit Taneja , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm: remove unused variable Message-ID: <20160211104921.GT11240@phenom.ffwll.local> Mail-Followup-To: Arnd Bergmann , David Airlie , linux-arm-kernel@lists.infradead.org, Rob Clark , David Herrmann , =?iso-8859-1?Q?St=E9phane?= Marchesin , Haixia Shi , Archit Taneja , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1455181810-3910161-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455181810-3910161-1-git-send-email-arnd@arndb.de> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 10:10:00AM +0100, Arnd Bergmann wrote: > After the drm_device_is_unplugged() was removed, the 'dev' variable is now > unused, and we get a warning for that: > > drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap': > drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' [-Werror=unused-variable] > > This removes the variable as well. > > Signed-off-by: Arnd Bergmann > Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check") Applied, thanks. -Daniel > --- > drivers/gpu/drm/msm/msm_fbdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c > index e119c2979509..d9759bf3482e 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma) > struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par; > struct msm_fbdev *fbdev = to_msm_fbdev(helper); > struct drm_gem_object *drm_obj = fbdev->bo; > - struct drm_device *dev = helper->dev; > int ret = 0; > > ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma); > -- > 2.7.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch