From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309AbcBKLw7 (ORCPT ); Thu, 11 Feb 2016 06:52:59 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35806 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbcBKLw5 (ORCPT ); Thu, 11 Feb 2016 06:52:57 -0500 Date: Thu, 11 Feb 2016 17:22:54 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Juri Lelli , Lists linaro-kernel , "linux-pm@vger.kernel.org" , Shilpasri G Bhat , Linux Kernel Mailing List Subject: Re: [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held Message-ID: <20160211115254.GC28558@vireshk> References: <2d9def751daa27c9aba57ab29a54003dd279e5e7.1454988792.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-02-16, 10:48, Rafael J. Wysocki wrote: > On Tue, Feb 9, 2016 at 4:46 AM, Viresh Kumar wrote: > > Also note that cpufreq_driver->stop_cpu() and ->exit() can get called > > while policy->rwsem is held. That shouldn't have any side effects > > though. > > The last paragraph is unclear. > > Is it supposed to mean that the change will cause > cpufreq_driver->stop_cpu() and ->exit() to be called under > policy->rwsem sometimes? Yeah, reworded it a bit .. Also note that, after this patch cpufreq_driver->stop_cpu() and ->exit() will get called while policy->rwsem is held, which wasn't the case earlier. That shouldn't have any side effects though. -- viresh