From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbcBKPsy (ORCPT ); Thu, 11 Feb 2016 10:48:54 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:54512 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbcBKPsx (ORCPT ); Thu, 11 Feb 2016 10:48:53 -0500 Date: Thu, 11 Feb 2016 16:48:51 +0100 From: Andrew Lunn To: Sascha Hauer Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: Re: [PATCH 2/2] net: dsa: remove phy_disconnect from error path Message-ID: <20160211154851.GA24249@lunn.ch> References: <1455187489-30771-1-git-send-email-s.hauer@pengutronix.de> <1455187489-30771-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455187489-30771-2-git-send-email-s.hauer@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 11:44:49AM +0100, Sascha Hauer wrote: > The phy has not been initialized, disconnecting it in the error > path results in a NULL pointer exception. Drop the phy_disconnect > from the error path. > > Signed-off-by: Sascha Hauer Hi Sascha The fix looks correct, since the phy should be bound to the device in the following dsa_slave_phy_setup() call. I'm not sure if Neil also fixed this... Anyway, Reviewed-by: Andrew Lunn Andrew > --- > net/dsa/slave.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 40b9ca7..91e3b2f 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -1194,7 +1194,6 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent, > if (ret) { > netdev_err(master, "error %d registering interface %s\n", > ret, slave_dev->name); > - phy_disconnect(p->phy); > ds->ports[port] = NULL; > free_netdev(slave_dev); > return ret; > -- > 2.7.0.rc3 >