From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbcBKRGd (ORCPT ); Thu, 11 Feb 2016 12:06:33 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36386 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbcBKRGb (ORCPT ); Thu, 11 Feb 2016 12:06:31 -0500 Date: Thu, 11 Feb 2016 17:06:27 +0000 From: Lee Jones To: "Maciej S. Szmigiero" Cc: linux-kernel , vbyravarasu@nvidia.com Subject: Re: mfd: tps65090: set regmap config reg counts properly Message-ID: <20160211170627.GF20693@x1> References: <56AE83E6.2010900@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56AE83E6.2010900@maciej.szmigiero.name> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 Jan 2016, Maciej S. Szmigiero wrote: > Regmap config max_register field should contain number of > device last register, however num_reg_defaults_raw field > should be set to register count instead > (usually one register more than max_register). > > tps65090 driver had both of these fields set to the same value, > fix this by introducing separate defines for max register > number and total count of registers. > > Signed-off-by: Maciej S. Szmigiero > --- > drivers/mfd/tps65090.c | 5 ++--- > include/linux/mfd/tps65090.h | 5 +++++ > 2 files changed, 7 insertions(+), 3 deletions(-) These 3 patches should really be submitted as a threaded set, so they stay together in one's inbox. Also, please submit patches using the subject line format expected by the subsystem. `git log --oneline -- ` helps with this. As you're a first time offender, I'll fix this for you this time. Applied, thanks. > diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c > index f88085ad9772..d7ec318c40c3 100644 > --- a/drivers/mfd/tps65090.c > +++ b/drivers/mfd/tps65090.c > @@ -30,7 +30,6 @@ > #include > > #define NUM_INT_REG 2 > -#define TOTAL_NUM_REG 0x18 > > #define TPS65090_INT1_MASK_VAC_STATUS_CHANGE 1 > #define TPS65090_INT1_MASK_VSYS_STATUS_CHANGE 2 > @@ -161,8 +160,8 @@ static bool is_volatile_reg(struct device *dev, unsigned int reg) > static const struct regmap_config tps65090_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > - .max_register = TOTAL_NUM_REG, > - .num_reg_defaults_raw = TOTAL_NUM_REG, > + .max_register = TPS65090_MAX_REG, > + .num_reg_defaults_raw = TPS65090_NUM_REGS, > .cache_type = REGCACHE_RBTREE, > .volatile_reg = is_volatile_reg, > }; > diff --git a/include/linux/mfd/tps65090.h b/include/linux/mfd/tps65090.h > index 0bf2708df150..67d144b3b8f9 100644 > --- a/include/linux/mfd/tps65090.h > +++ b/include/linux/mfd/tps65090.h > @@ -77,6 +77,11 @@ enum { > #define TPS65090_REG_CG_CTRL5 0x09 > #define TPS65090_REG_CG_STATUS1 0x0a > #define TPS65090_REG_CG_STATUS2 0x0b > +#define TPS65090_REG_AD_OUT1 0x17 > +#define TPS65090_REG_AD_OUT2 0x18 > + > +#define TPS65090_MAX_REG TPS65090_REG_AD_OUT2 > +#define TPS65090_NUM_REGS (TPS65090_MAX_REG + 1) > > struct tps65090 { > struct device *dev; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog