[PATCH] mfd: syscon: return ENOTSUPP instead of ENOSYS when disabled

[PATCH] mfd: syscon: return ENOTSUPP instead of ENOSYS when disabled

[Philipp Zabel]

When CONFIG_MFD_SYSCON is disabled, have the function stubs return
ENOTSUPP to indicate the syscon functionality is not available.
There are currently no callers that depend on the ENOSYS return value.

This patchfixes a checkpatch warning:
    WARNING: ENOSYS means 'invalid syscall nr' and nothing else

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 include/linux/mfd/syscon.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
index 75e543b..1088149 100644
--- a/include/linux/mfd/syscon.h
+++ b/include/linux/mfd/syscon.h
@@ -29,24 +29,24 @@ extern struct regmap *syscon_regmap_lookup_by_phandle(
 #else
 static inline struct regmap *syscon_node_to_regmap(struct device_node *np)
 {
-	return ERR_PTR(-ENOSYS);
+	return ERR_PTR(-ENOTSUPP);
 }
 
 static inline struct regmap *syscon_regmap_lookup_by_compatible(const char *s)
 {
-	return ERR_PTR(-ENOSYS);
+	return ERR_PTR(-ENOTSUPP);
 }
 
 static inline struct regmap *syscon_regmap_lookup_by_pdevname(const char *s)
 {
-	return ERR_PTR(-ENOSYS);
+	return ERR_PTR(-ENOTSUPP);
 }
 
 static inline struct regmap *syscon_regmap_lookup_by_phandle(
 					struct device_node *np,
 					const char *property)
 {
-	return ERR_PTR(-ENOSYS);
+	return ERR_PTR(-ENOTSUPP);
 }
 #endif
 
-- 
2.7.0.rc3

Re: [PATCH] mfd: syscon: return ENOTSUPP instead of ENOSYS when disabled

[Lee Jones]

On Fri, 29 Jan 2016, Philipp Zabel wrote:

> When CONFIG_MFD_SYSCON is disabled, have the function stubs return
> ENOTSUPP to indicate the syscon functionality is not available.
> There are currently no callers that depend on the ENOSYS return value.
> 
> This patchfixes a checkpatch warning:
>     WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  include/linux/mfd/syscon.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 75e543b..1088149 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -29,24 +29,24 @@ extern struct regmap *syscon_regmap_lookup_by_phandle(
>  #else
>  static inline struct regmap *syscon_node_to_regmap(struct device_node *np)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  static inline struct regmap *syscon_regmap_lookup_by_compatible(const char *s)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  static inline struct regmap *syscon_regmap_lookup_by_pdevname(const char *s)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  static inline struct regmap *syscon_regmap_lookup_by_phandle(
>  					struct device_node *np,
>  					const char *property)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  #endif
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog