From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbcBKRL2 (ORCPT ); Thu, 11 Feb 2016 12:11:28 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35688 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbcBKRL1 (ORCPT ); Thu, 11 Feb 2016 12:11:27 -0500 Date: Thu, 11 Feb 2016 17:11:22 +0000 From: Lee Jones To: Philipp Zabel Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: syscon: return ENOTSUPP instead of ENOSYS when disabled Message-ID: <20160211171122.GI20693@x1> References: <1454056939-16860-1-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454056939-16860-1-git-send-email-p.zabel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016, Philipp Zabel wrote: > When CONFIG_MFD_SYSCON is disabled, have the function stubs return > ENOTSUPP to indicate the syscon functionality is not available. > There are currently no callers that depend on the ENOSYS return value. > > This patchfixes a checkpatch warning: > WARNING: ENOSYS means 'invalid syscall nr' and nothing else > > Signed-off-by: Philipp Zabel > --- > include/linux/mfd/syscon.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h > index 75e543b..1088149 100644 > --- a/include/linux/mfd/syscon.h > +++ b/include/linux/mfd/syscon.h > @@ -29,24 +29,24 @@ extern struct regmap *syscon_regmap_lookup_by_phandle( > #else > static inline struct regmap *syscon_node_to_regmap(struct device_node *np) > { > - return ERR_PTR(-ENOSYS); > + return ERR_PTR(-ENOTSUPP); > } > > static inline struct regmap *syscon_regmap_lookup_by_compatible(const char *s) > { > - return ERR_PTR(-ENOSYS); > + return ERR_PTR(-ENOTSUPP); > } > > static inline struct regmap *syscon_regmap_lookup_by_pdevname(const char *s) > { > - return ERR_PTR(-ENOSYS); > + return ERR_PTR(-ENOTSUPP); > } > > static inline struct regmap *syscon_regmap_lookup_by_phandle( > struct device_node *np, > const char *property) > { > - return ERR_PTR(-ENOSYS); > + return ERR_PTR(-ENOTSUPP); > } > #endif > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog