From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbcBKRgT (ORCPT ); Thu, 11 Feb 2016 12:36:19 -0500 Received: from coss8.exosec.net ([91.90.99.101]:44080 "EHLO mx1.exosec.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751329AbcBKRgS (ORCPT ); Thu, 11 Feb 2016 12:36:18 -0500 X-Greylist: delayed 1419 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Feb 2016 12:36:18 EST Date: Thu, 11 Feb 2016 18:12:37 +0100 From: Willy TARREAU To: Jiri Slaby Cc: gregkh@linuxfoundation.org, arnd@arndb.de, linux-kernel@vger.kernel.org, Daniel Chromik , Ksenija Stanojevic Subject: Re: [PATCH] misc: panel, convert struct to bitmap Message-ID: <20160211171237.GP25328@haproxy.com> References: <1455193763-14258-1-git-send-email-jslaby@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455193763-14258-1-git-send-email-jslaby@suse.cz> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 01:29:23PM +0100, Jiri Slaby wrote: > From: Daniel Chromik > > There is an anonymous struct which is actually used as a bitmap. So > convert the struct to a bitmap and change code accordingly where > needed. > > This also allows for a cleanup of set_data_bits and set_ctrl_bits as > they can use a common helper now. The helper can also be converted to > a for loop instead of doing bit OR. And given it is a for loop now, > bit masking (using BIT_MSK) is moved from the callers there too. > > Signed-off-by: Daniel Chromik > Signed-off-by: Jiri Slaby > Cc: Willy Tarreau > Cc: Ksenija Stanojevic Acked-by: Willy Tarreau Thanks, Willy