From: Greg KH <gregkh@linuxfoundation.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"
Date: Thu, 11 Feb 2016 09:19:41 -0800 [thread overview]
Message-ID: <20160211171941.GA29378@kroah.com> (raw)
In-Reply-To: <1455206051-8633-1-git-send-email-ulf.hansson@linaro.org>
On Thu, Feb 11, 2016 at 04:54:11PM +0100, Ulf Hansson wrote:
> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
>
> Revert this change as it causes a sysfs path to change and therefore
> introduces and ABI regression. More precisely Android's vold is not being
> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
> the path becomes changed to: "/sys/module/mmc_block/..."
>
> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
> module")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Please also add a "cc: stable..." tag to the patch so it gets picked up
in stable kernel releases.
thanks,
greg k-h
next prev parent reply other threads:[~2016-02-11 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 15:54 [PATCH] Revert "mmc: block: don't use parameter prefix if built as module" Ulf Hansson
2016-02-11 15:57 ` Ulf Hansson
2016-02-11 21:52 ` John Stultz
2016-02-11 17:19 ` Greg KH [this message]
2016-02-12 10:06 ` Ulf Hansson
2016-02-12 16:32 ` Greg KH
2016-03-03 13:37 ` Ulf Hansson
2016-03-03 15:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211171941.GA29378@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).