From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbcBKSRz (ORCPT ); Thu, 11 Feb 2016 13:17:55 -0500 Received: from mail.skyhub.de ([78.46.96.112]:55599 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbcBKSRy (ORCPT ); Thu, 11 Feb 2016 13:17:54 -0500 Date: Thu, 11 Feb 2016 19:17:49 +0100 From: Borislav Petkov To: Boris Ostrovsky Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Message-ID: <20160211181749.GF5565@pd.tnic> References: <1455203598-14378-1-git-send-email-boris.ostrovsky@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455203598-14378-1-git-send-email-boris.ostrovsky@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 10:13:18AM -0500, Boris Ostrovsky wrote: > Commit a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on > paravirt") added a paravirt test in microcode_init(), primarily to avoid > making mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls > On 32-bit kernels this callchain ends up using __pa_nodebug() macro > which is invalid for Xen PV guests. > > A subsequent commit, fbae4ba8c4a3 ("x86, microcode: Reload microcode on > resume"), eliminated this callchain thus making a18a0f6850d4 > unnecessary. > > Signed-off-by: Boris Ostrovsky > --- > arch/x86/kernel/cpu/microcode/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.