From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbcBKUvU (ORCPT ); Thu, 11 Feb 2016 15:51:20 -0500 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:2090 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbcBKUvR (ORCPT ); Thu, 11 Feb 2016 15:51:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AMDwDw87xWPBATLHleDhoBAoMPgT+GYoF5nWABAQaLaziFDYQIhgcEAgKBNE0BAQEBAQEHAQEBAUE/hEIBAQQnExwzCAMYCSUPBSUDBxoBEogZwUQqGIUyhH6IbAEElneNSo5+jj6EDE8oLohTAQEB Date: Fri, 12 Feb 2016 07:50:49 +1100 From: Dave Chinner To: Ross Zwisler , Jan Kara , linux-kernel@vger.kernel.org, "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Jan Kara , Matthew Wilcox , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org, xfs@oss.sgi.com Subject: Re: [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS Message-ID: <20160211205049.GJ19486@dastard> References: <1455137336-28720-1-git-send-email-ross.zwisler@linux.intel.com> <20160211124304.GI21760@quack.suse.cz> <20160211194922.GA5260@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160211194922.GA5260@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 12:49:22PM -0700, Ross Zwisler wrote: > I think the plan of unsetting S_DAX on bdev->bd_inode when we mount will save > us from this, as long as we do it super early in the mount process. I think that S_DAX should not be set on the block device by default in the first place. If we've been surprised by unexpected behaviour, then I'm sure there are going to be other surprises waiting for us. DAX default policy should be opt-in, not opt-out. Cheers, Dave. -- Dave Chinner david@fromorbit.com