From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbcBLAiC (ORCPT ); Thu, 11 Feb 2016 19:38:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43395 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbcBLAiA (ORCPT ); Thu, 11 Feb 2016 19:38:00 -0500 Date: Thu, 11 Feb 2016 16:37:57 -0800 From: Stephen Boyd To: Georgi Djakov Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v6 0/2] Add initial support for RPM clocks Message-ID: <20160212003757.GD4847@codeaurora.org> References: <1450182602-6996-1-git-send-email-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450182602-6996-1-git-send-email-georgi.djakov@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15, Georgi Djakov wrote: > > .../devicetree/bindings/clock/qcom,rpmcc.txt | 37 ++ > drivers/clk/qcom/Kconfig | 29 ++ > drivers/clk/qcom/Makefile | 2 + > drivers/clk/qcom/clk-rpm.c | 290 +++++++++++++ > drivers/clk/qcom/clk-rpm.h | 71 ++++ Do we need this header file? > drivers/clk/qcom/clk-smd-rpm.c | 433 ++++++++++++++++++++ > drivers/clk/qcom/clk-smd-rpm.h | 142 +++++++ And this one too? >>From what I can tell they're only going to be included by the clk-rpm and clk-smd-rpm C files. We can also avoid exporting the RPM ops then if we're going to make the C files into full blown platform drivers. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project