linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks
Date: Thu, 11 Feb 2016 16:41:26 -0800	[thread overview]
Message-ID: <20160212004126.GE4847@codeaurora.org> (raw)
In-Reply-To: <1450182602-6996-3-git-send-email-georgi.djakov@linaro.org>

On 12/15, Georgi Djakov wrote:
> diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
> new file mode 100644
> index 000000000000..7b0e85eefe70
> --- /dev/null
> +++ b/drivers/clk/qcom/clk-rpm.c
> @@ -0,0 +1,290 @@
> +
> +static int clk_rpm_prepare(struct clk_hw *hw)
> +{
> +	struct clk_rpm *r = to_clk_rpm(hw);
> +	unsigned long rate = r->rate;
> +	int ret = 0;
> +
> +	mutex_lock(&rpm_clk_lock);
> +
> +	if (!rate)
> +		goto out;
> +
> +	if (r->branch)
> +		rate = !!rate;
> +
> +	ret = clk_rpm_set_rate_active(r, rate);
> +
> +	if (ret)
> +		goto out;
> +
> +out:
> +	if (!ret)
> +		r->enabled = true;
> +
> +	mutex_unlock(&rpm_clk_lock);
> +
> +	return ret;
> +}

I don't see any "peer" code in this file. Is there a reason we're
leaving out the active only vs active + sleep set style clocks?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-02-12  0:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 12:30 [PATCH v6 0/2] Add initial support for RPM clocks Georgi Djakov
2015-12-15 12:30 ` [PATCH v6 1/2] clk: qcom: Add support for SMD-RPM Clocks Georgi Djakov
2015-12-15 12:30 ` [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks Georgi Djakov
2016-02-12  0:41   ` Stephen Boyd [this message]
2016-02-22 15:32     ` Georgi Djakov
2016-03-13 13:06   ` Bjorn Andersson
2016-03-15 17:16     ` Georgi Djakov
2016-02-12  0:37 ` [PATCH v6 0/2] Add initial support for RPM clocks Stephen Boyd
2016-02-22 15:29   ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212004126.GE4847@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=georgi.djakov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).