From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbcBLGj4 (ORCPT ); Fri, 12 Feb 2016 01:39:56 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:31047 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbcBLGjz (ORCPT ); Fri, 12 Feb 2016 01:39:55 -0500 Date: Fri, 12 Feb 2016 09:39:40 +0300 From: Dan Carpenter To: Liam Girdwood , Georgi Djakov Cc: Mark Brown , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] regulator: qcom-saw: testing the wrong variable Message-ID: <20160212063940.GC22756@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We accidentally test "config.regmap" which is zero instead of "vreg->regmap". Fixes: 18bba3b50355 ('regulator: qcom-saw: Add support for SAW regulators') Signed-off-by: Dan Carpenter diff --git a/drivers/regulator/qcom_saw-regulator.c b/drivers/regulator/qcom_saw-regulator.c index c800f16..c00f0df 100644 --- a/drivers/regulator/qcom_saw-regulator.c +++ b/drivers/regulator/qcom_saw-regulator.c @@ -186,8 +186,8 @@ static int qcom_saw_regulator_probe(struct platform_device *pdev) vreg->regmap = syscon_node_to_regmap(saw_np); of_node_put(saw_np); - if (IS_ERR(config.regmap)) - return PTR_ERR(config.regmap); + if (IS_ERR(vreg->regmap)) + return PTR_ERR(vreg->regmap); snprintf(name, sizeof(name), "krait%d", cpu);