From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458AbcBLJIv (ORCPT ); Fri, 12 Feb 2016 04:08:51 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33328 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbcBLJIn (ORCPT ); Fri, 12 Feb 2016 04:08:43 -0500 Date: Fri, 12 Feb 2016 09:08:37 +0000 From: Lee Jones To: Sudeep Holla Cc: Jassi Brar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mailbox: mailbox-test: fix the compatible string Message-ID: <20160212090837.GQ20693@x1> References: <1455210808-29395-1-git-send-email-sudeep.holla@arm.com> <1455210808-29395-3-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455210808-29395-3-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2016, Sudeep Holla wrote: > Underscores are usually forbidden in the compatible strings. So lets > remove it before the first users of this is seen. > > Cc: Jassi Brar > Cc: Lee Jones > Signed-off-by: Sudeep Holla Acked-by: Lee Jones > --- > Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 2 +- > drivers/mailbox/mailbox-test.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > index b61eec920359..351f612673fc 100644 > --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > @@ -44,7 +44,7 @@ Optional properties > Example: > > mailbox_test { > - compatible = "mailbox_test"; > + compatible = "mailbox-test"; > reg = <0x[shared_memory_address], [shared_memory_size]>; > mboxes = <&mailbox2 0 1>, <&mailbox0 2 1>; > mbox-names = "tx", "rx"; > diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c > index 3813f6d9eba9..036a852b5fa1 100644 > --- a/drivers/mailbox/mailbox-test.c > +++ b/drivers/mailbox/mailbox-test.c > @@ -342,7 +342,7 @@ static int mbox_test_remove(struct platform_device *pdev) > } > > static const struct of_device_id mbox_test_match[] = { > - { .compatible = "mailbox_test" }, > + { .compatible = "mailbox-test" }, > {}, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog