From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbcBLJMf (ORCPT ); Fri, 12 Feb 2016 04:12:35 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37868 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbcBLJMZ (ORCPT ); Fri, 12 Feb 2016 04:12:25 -0500 Date: Fri, 12 Feb 2016 09:12:18 +0000 From: Lee Jones To: Sudeep Holla Cc: Jassi Brar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mailbox: mailbox-test: use print_hex_dump_bytes to allow dynamic printk Message-ID: <20160212091218.GR20693@x1> References: <1455210808-29395-1-git-send-email-sudeep.holla@arm.com> <1455210808-29395-4-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455210808-29395-4-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2016, Sudeep Holla wrote: > Reduce the logging from info to debug. Also use print_hex_dump_bytes > instead as it has support for dynamic printk providing options to > conditionally enable/disable these logs. Printing out the data in this way is kinda the point of the driver. But if you don't have a use for it, then I guess it's okay to downgrade it to DEBUG, as turning debug on, or hacking the driver back again are trivial actions. > Cc: Jassi Brar > Cc: Lee Jones > Signed-off-by: Sudeep Holla > --- > drivers/mailbox/mailbox-test.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c > index 036a852b5fa1..f690f11969a1 100644 > --- a/drivers/mailbox/mailbox-test.c > +++ b/drivers/mailbox/mailbox-test.c > @@ -113,15 +113,15 @@ static ssize_t mbox_test_message_write(struct file *filp, > * MMIO to subsequently pass the message through > */ > if (tdev->mmio && tdev->signal) { > - print_hex_dump(KERN_INFO, "Client: Sending: Signal: ", DUMP_PREFIX_ADDRESS, > - MBOX_BYTES_PER_LINE, 1, tdev->signal, MBOX_MAX_SIG_LEN, true); > + print_hex_dump_bytes("Client: Sending: Signal: ", DUMP_PREFIX_ADDRESS, > + tdev->signal, MBOX_MAX_SIG_LEN); > > data = tdev->signal; > } else > data = tdev->message; > > - print_hex_dump(KERN_INFO, "Client: Sending: Message: ", DUMP_PREFIX_ADDRESS, > - MBOX_BYTES_PER_LINE, 1, tdev->message, MBOX_MAX_MSG_LEN, true); > + print_hex_dump_bytes("Client: Sending: Message: ", DUMP_PREFIX_ADDRESS, > + tdev->message, MBOX_MAX_MSG_LEN); > > ret = mbox_send_message(tdev->tx_channel, data); > if (ret < 0) > @@ -222,13 +222,11 @@ static void mbox_test_receive_message(struct mbox_client *client, void *message) > spin_lock_irqsave(&tdev->lock, flags); > if (tdev->mmio) { > memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN); > - print_hex_dump(KERN_INFO, "Client: Received [MMIO]: ", > - DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1, > - tdev->rx_buffer, MBOX_MAX_MSG_LEN, true); > + print_hex_dump_bytes("Client: Received [MMIO]: ", DUMP_PREFIX_ADDRESS, > + tdev->rx_buffer, MBOX_MAX_MSG_LEN); > } else if (message) { > - print_hex_dump(KERN_INFO, "Client: Received [API]: ", > - DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1, > - message, MBOX_MAX_MSG_LEN, true); > + print_hex_dump_bytes("Client: Received [API]: ", DUMP_PREFIX_ADDRESS, > + message, MBOX_MAX_MSG_LEN); > memcpy(tdev->rx_buffer, message, MBOX_MAX_MSG_LEN); > } > spin_unlock_irqrestore(&tdev->lock, flags); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog