From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751528AbcBLJR3 (ORCPT ); Fri, 12 Feb 2016 04:17:29 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36905 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbcBLJRZ (ORCPT ); Fri, 12 Feb 2016 04:17:25 -0500 Date: Fri, 12 Feb 2016 09:17:18 +0000 From: Lee Jones To: Sudeep Holla Cc: Jassi Brar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer Message-ID: <20160212091718.GT20693@x1> References: <1455210808-29395-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455210808-29395-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Feb 2016, Sudeep Holla wrote: > Hi Lee, Jassi, > > Assuming mailbox-test was designed to be generic, I am trying to extend > it to support single channel with separate Tx and Rx buffer. With these > changes I am able to test arm_mhu driver. However I couldn't understand > the intention of converting buffer to ASCII hex dump in read method. > I have a local change to remove that so that it can deal with any data > in any format(e.g. some protocol format) Not sure quite what you mean. Hexdump can handle any data? If the hex value read isn't an ASCII value, a '.' is printed on the right hand side. What data are you expecting that you can't analyse with hexdump? > and userspace can deal with the > actual interpretation of the data. Let me know your thoughts on that. > > Regards, > Sudeep > > Sudeep Holla (4): > mailbox: mailbox-test: rename driver as generic test driver > mailbox: mailbox-test: fix the compatible string > mailbox: mailbox-test: use print_hex_dump_bytes to allow dynamic > printk > mailbox: mailbox-test: add support for separate tx/rx buffer with > single channel > > .../devicetree/bindings/mailbox/sti-mailbox.txt | 2 +- > drivers/mailbox/mailbox-test.c | 50 ++++++++++++---------- > 2 files changed, 29 insertions(+), 23 deletions(-) > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog